Charles/sp26 #17
Open
Charles/sp26 #17
+14,163
−1,844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I don't expect either of you to thoroughly review this and I apologize for the amount of stuff happening here... I don't want to keep adding more and have it get worse, so this is good so everyone can make smaller changes and we're all on the same page... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Decent baseline for Spring 2026 dev work
Changes Made
MVP for all features worked on last semester minus event space.
There are looming issues with dates in the app currently. We seem to be sending the backend incorrect dates for completed transactions, and I plan to keep investigating this. All other dates in the app are displaying properly though...
Test Coverage
Next Steps (optional)
detailed list of things that are broken:
scrolling in the availability grid is a little buggy, and you cant properly set availabilityt for late times (so a fix would be changing the geometry reader logic or not allowing vertical scrolling (reducing # of times u can see))
dates may not be properly sent to the backend for reviews (you can test this by running 2 simulators or seeding with test data/reviews)
the ui for the reviews section on an external users page is ugly
the ui for submitting reviews is ugly
users can see their own "user credibility view" (i.e. if you find your own post on the homepage, you can click on your profile and see what others see, rather than going to your own profile view)
users can propose prior times to meet (i.e. if its feb 1, 10:00 am, users can select 8 am as time to meet)
not sure if this is really an issue but there can be a lot of notifications lol, users can delete them but i feel like we don't need notis for some things like bookmarks
Related PRs or Issues (optional)
Andrew's notifications PR was merged into this...
Screenshots (optional)